Fixed DeprecationWarning on pkg_import.#112
Open
numshub wants to merge 2 commits into4teamwork:masterfrom
Open
Fixed DeprecationWarning on pkg_import.#112numshub wants to merge 2 commits into4teamwork:masterfrom
numshub wants to merge 2 commits into4teamwork:masterfrom
Conversation
waketzheng
suggested changes
Jul 19, 2025
waketzheng
left a comment
waketzheng
left a comment
There was a problem hiding this comment.
Should be import importlib.resources as importlib_resources instead of import importlib_resources
waketzheng
reviewed
Jul 19, 2025
docxcompose/properties.py
Outdated
| from six import binary_type | ||
| from six import text_type | ||
| import pkg_resources | ||
| #import pkg_resources |
There was a problem hiding this comment.
Remove it, do not leave it as a comment line. So does line 112 and 113.
Removed old lines of code Changed import of importlib.resources
Author
|
Fixed as requested in review. |
|
This MR seems to be a duplicate of #91 |
|
I think PR #113 should be preferred :) |
|
I have published a new pypi package called docxcompose3 https://pypi.org/project/docxcompose3/ You should be able to simply swap your dependency to this and then work with newer setuptools Hopefully this can help others :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgraded code to replace pkg_resources.resource_string with equivalent importlib functionality.